fix: Treasury - address format #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
reviewed
Nov 20, 2025
| full_data[0..4].copy_from_slice(b"modl"); | ||
| full_data[4..12].copy_from_slice(b"py/trsry"); | ||
| let treasury_account = subxt::utils::AccountId32(full_data); | ||
| // Get Treasury account ID using the same method as runtime |
Contributor
There was a problem hiding this comment.
How are we supposed to make transactions on behalf of the treasury account if there's no private key? Only by governance?
Contributor
There was a problem hiding this comment.
This is not a regression so not a blocker - just asking
Contributor
There was a problem hiding this comment.
Wait shouldn't this be
let treasury_account: AccountId32 =
quantus_runtime::configs::TreasuryPalletId::get().into_account_truncating();
n13
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.