chore: Finalized flag in all commands #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
approved these changes
Dec 11, 2025
Contributor
n13
left a comment
n13
left a comment
There was a problem hiding this comment.
This is definitely an improvement, streamlining the codebase.
Nice.
I want to replace the finalized flag with a TxExecutionOptions struct which has finalized, instant (submit without wait), and output-unsigned which outputs the extrinsic unsigned but ready to sign so a hardware wallet can pick it up
This is in my branch but very messy so better I re-implement this with this new much cleaner version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.