Replace excon with Net::HTTP to support Unzer AWS proxy #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmurrays
reviewed
Mar 3, 2025
ianmurrays
reviewed
Mar 4, 2025
|
|
||
| if !options.fetch(:raw, false) && res.headers["Content-Type"] =~ CONTENT_TYPE_JSON_REGEX | ||
| res.body = JSON.parse(res.body, options[:json_opts] || @connection.data[:json_opts]) | ||
| if !options.fetch(:raw, false) && res["content-type"] =~ CONTENT_TYPE_JSON_REGEX |
There was a problem hiding this comment.
Can we be 100% sure the headers are always lowercase?
There was a problem hiding this comment.
Seems so https://github.com/ruby/net-http/blob/master/lib/net/http/header.rb#L40-L47 or at least they're treated as case-insensitive
| end | ||
| status_code = res.code.to_i | ||
| body = res.body | ||
| headers = res.each_header.to_h |
There was a problem hiding this comment.
There's a pretty big breaking change here, if we can't guarantee the headers "upper/lower-caseness".
Perhaps we could consider returning a Hash-like object that behaves like Net::HTTPHeader, because otherwise stuff might break when we or externals upgrade to version 4.
Contributor
Author
There was a problem hiding this comment.
Which is the reason for the major version change.
Contributor
Author
There was a problem hiding this comment.
Besides changes in underlying client errors
ianmurrays
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.