Skip to content

[7.2.1] Fix MXR writes #4494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
causten wants to merge 1 commit into
base: release/rocm-rel-7.2
Choose a base branch
from
+17 −1
Open

[7.2.1] Fix MXR writes #4494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/msgpack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ constexpr std::size_t msgpack_size_limit = std::numeric_limits<uint32_t>::max()
template <class Range>
static std::size_t msgpack_chunk_size(const Range& r)
{
return 1 + (r.size() - 1) / msgpack_size_limit;
return 1 + (std::max<size_t>(1, r.size()) - 1) / msgpack_size_limit;
}

template <class Iterator, class F>
Expand Down Expand Up @@ -81,6 +81,7 @@ MSGPACK_API_VERSION_NAMESPACE(MSGPACK_DEFAULT_API_NS)
break;
}
case msgpack::type::FLOAT32:
/* Intentional Fall Through This is due to value encoding floats as double. */
case msgpack::type::FLOAT64: {
v = o.as<double>();
break;
Expand Down
15 changes: 15 additions & 0 deletions test/msgpack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,5 +220,20 @@ TEST_CASE(test_msgpack_binary2)
});
EXPECT(migraphx::to_msgpack(bin) == msgpack_buffer(bin));
}

TEST_CASE(test_msgpack_binary_empty)
{
migraphx::value::binary bin{};
EXPECT(migraphx::to_msgpack(bin) == msgpack_buffer(bin));
}

TEST_CASE(test_msgpack_binary_roundtrip_empty)
{
migraphx::value bin = migraphx::value::binary{};
auto buffer = migraphx::to_msgpack(bin);
auto mp = migraphx::from_msgpack(buffer);
EXPECT(mp == bin);
}

#endif
int main(int argc, const char* argv[]) { test::run(argc, argv); }
Loading