Remove HIP macros around std:: math functions #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextmagro
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
| hipify_extra_files_only=False, | ||
| show_detailed=False) | ||
| show_detailed=False, | ||
| no_math_replace=True) |
Collaborator
There was a problem hiding this comment.
I didn't find this no_math_replace option in hipify_torch. Could you post the reference URL to it?
Contributor
Author
There was a problem hiding this comment.
This PR requires this hipify-torch commit which introduces no_math_replace:
Collaborator
There was a problem hiding this comment.
Alternatively, we can use commit from your hipify PR branch for time being
wangye805
approved these changes
Oct 23, 2025
wenchenvincent
requested changes
Oct 27, 2025
Collaborator
wenchenvincent
left a comment
wenchenvincent
left a comment
There was a problem hiding this comment.
@alextmagro We will need to add the hipify_torch changes in this PR. You can either wait for your hipify_torch PR to be merged or if it takes too long, we can use your hipify_torch feature branch for merging this TE PR and update to hipify_torch main later.
ipanfilo
approved these changes
Oct 29, 2025
wenchenvincent
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes several HIP workarounds for std:: math hipifications.
Requires ROCm/hipify_torch#82 prior to merging.