Skip to content

Do not fail CI on known failed JAX test #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ipanfilo wants to merge 1 commit into
base: dev
Choose a base branch
from
+16 −2
Open

Do not fail CI on known failed JAX test #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ci/_utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2024-2025, Advanced Micro Devices, Inc. All rights reserved.
# Copyright (c) 2024-2026, Advanced Micro Devices, Inc. All rights reserved.
#
# See LICENSE for license information.

Expand All @@ -25,20 +25,28 @@ export CI=1

_script_error_count=0
_run_error_count=0
_ignored_error_count=0
TEST_ERROR_IGNORE=""

script_error() {
_script_error_count=$((_script_error_count+1))
test "$@" && echo $@ >&2
}

test_run_error() {
if [ -n "$TEST_ERROR_IGNORE" ]; then
_ignored_error_count=$((_ignored_error_count+1))
test -n "$@" && echo "Ignore error in test $@" >&2
return
fi
_run_error_count=$((_run_error_count+1))
test -n "$@" && echo "Error in test $@" >&2
}

return_run_results() {
test $_script_error_count -ne 0 && echo Detected $_script_error_count script errors during tests run at level $TEST_LEVEL >&2
test $_run_error_count -ne 0 && echo Got $_run_error_count test errors during run at level $TEST_LEVEL >&2
test $_ignored_error_count -ne 0 && echo Ignored $_ignored_error_count test errors during run at level $TEST_LEVEL >&2
test $_run_error_count -eq 0 -a $_script_error_count -eq 0
}

Expand Down
8 changes: 7 additions & 1 deletion ci/jax.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh
# Copyright (c) 2024-2025, Advanced Micro Devices, Inc. All rights reserved.
# Copyright (c) 2024-2026, Advanced Micro Devices, Inc. All rights reserved.
#
# See LICENSE for license information.

Expand Down Expand Up @@ -79,7 +79,13 @@ run_test_config_mgpu() {
else
_dfa_level=3
fi
# Do not fail automated CI if test_distributed_fused_attn is hung
# If the sctipt run w/o TEST_LEVEL the test error will be honored
if [ "$TEST_LEVEL" -le 3 ]; then
TEST_ERROR_IGNORE="1"
fi
run $_dfa_level test_distributed_fused_attn.py $_timeout_args
TEST_ERROR_IGNORE=""
run_default_fa 3 test_distributed_layernorm.py
run_default_fa 2 test_distributed_layernorm_mlp.py $_timeout_args
run_default_fa 3 test_distributed_softmax.py
Expand Down