Skip to content

Conversation

@ApoorvaKalyani
Copy link
Contributor

@ApoorvaKalyani ApoorvaKalyani commented Dec 19, 2025

Proposed changes

This MR is to add the wmma support for Grouped convolution backward data.
1_) The changes are inline with WMMA v3.
2) Added new device implementation for WMMA v3.
3) Modified a gridwise implementation to support the new WMMA v3 implementation.
4) Added initial round of vanilla instances , tests and examples for FP16 and BF16 types.
5) All the instances and tests just support NHWGCxGKYXC layout.
6) FP32 is unsupported.
7) Extended to adding support bilinear and scale flavours with new device implementation.
8) Ran some performance benchmarks for vanilla , bilinear and scale instances , tuned and tested on RDNA4 and updated tuned instances.
9) Tested the tuned instances on RDNA3.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@ApoorvaKalyani ApoorvaKalyani force-pushed the streamhpc/grouped_conv_bwd_data branch from 3df9e91 to 53fb53e Compare December 19, 2025 13:58
@ApoorvaKalyani ApoorvaKalyani changed the title Streamhpc/grouped conv bwd data Grouped convolution backward data WMMA v3 implementation Dec 19, 2025
@krithalith krithalith force-pushed the streamhpc/grouped_conv_bwd_data branch from f18b54b to 5eaffb1 Compare December 19, 2025 14:56
@ApoorvaKalyani ApoorvaKalyani force-pushed the streamhpc/grouped_conv_bwd_data branch 2 times, most recently from d124243 to 5686391 Compare December 19, 2025 17:14
@ApoorvaKalyani ApoorvaKalyani marked this pull request as ready for review December 20, 2025 22:44
@ApoorvaKalyani ApoorvaKalyani force-pushed the streamhpc/grouped_conv_bwd_data branch from d5e660e to 9e3a0be Compare December 23, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants