Skip to content

Conversation

@rocm-devops
Copy link

…tiple databases per file and fixed duplication of definitions in otf2

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

  • [ X] Bug Fix

Technical details

  1. Extended test environment to handle otf2 from multiprocess inputs.
  2. Fixed reporting of "deallocate" by multiprocess otf2 files, by placing these tracks under their corresponding thread groups directly, bypassing placing them under "agent" groups since deallocations do not have agents assigned.
  3. Fixed definition-duplication error thrown by otf2 reader when reading otf2 generated by 2 process inputs, by making "existing" hash list global for all processes, which allows to control which shared string definitions has been already added.

Added/updated tests?

  • [X ] Yes, validation test for otf2 for mutliprocess input is added

Updated CHANGELOG?

  • [ X] No, Does not apply to this PR.

Added/Updated documentation?

  • [ X] No, Does not apply to this PR.

…urrent change and adjusted multiproc validation for otf2 is placed back
@rocm-devops rocm-devops requested a review from jrmadsen as a code owner August 7, 2025 19:05
@rocm-devops
Copy link
Author

Manual review required for 4e885c
Assigned Auditors: @jalan

@rocm-devops rocm-devops requested a review from t-tye as a code owner August 7, 2025 19:05
@rocm-devops
Copy link
Author

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@jayhawk-commits
Copy link
Contributor

This pull request has merge conflicts that need to be resolved. It cannot be imported to the ROCm/rocm-systems repo automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants