Skip to content

Conversation

@rocm-devops
Copy link

PR Details

This PR aims to remove bitfields from the thread trace and thread trace decoder struct definitions, for a stable ABI.

  • Added a translation layer in the SDK if the decoder version is < 0.2.0
  • No translation layer if decoder version is >= 0.2.0
  • The current decoder will keep the API with bitfields in order to not break pre-release SDK versions. After 7.0 release, we can release the 0.2.0 decoder and remove this layer from the SDK.
  • Added a rocprofiler_shader_timestamp_t type to represent timestamp in shader clock units/reference
  • Increased thread trace default buffer size (some users complained v2's number was bigger)
  • Renamed some struct fields:
    • "CU" -> "cu"
    • "eventsX" -> "eventX" (it is just one event)
    • "begin_time" to "start_time" as it's more intuitive
    • These changes have no ABI implication for the decoder, since they kept the same variable types.

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Continuous Integration

Technical details

Added/updated tests?

  • Yes
  • No, Does not apply to this PR.

Updated CHANGELOG?

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

ApoKalipse-V and others added 27 commits June 18, 2025 14:11
Co-authored-by: Indic, Vladimir <Vladimir.Indic@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
@rocm-devops
Copy link
Author

Manual review required for b0e2be
Assigned Auditors: @lpopescu

@rocm-devops
Copy link
Author

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@rocm-devops
Copy link
Author

@jomadsen_amdeng reverted the make_pair because clang tidy was complaining about temporary object with explicit pair<>

@rocm-devops
Copy link
Author

Manual review required for 62c221
Assigned Auditors: @jalan

@rocm-devops
Copy link
Author

Manual review required for 3a314e
Assigned Auditors: @anikitin

@rocm-devops
Copy link
Author

Manual review required for 6cef5e
Assigned Auditors: @udaykikr

@jayhawk-commits
Copy link
Contributor

This pull request has merge conflicts that need to be resolved. It cannot be imported to the ROCm/rocm-systems repo automatically.

@amd-hsivasun amd-hsivasun added ready for 2nd review PR has one approval, needs second review ias-review bug fix labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix ias-review ready for 2nd review PR has one approval, needs second review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants