Skip to content

Conversation

@SwRaw
Copy link
Contributor

@SwRaw SwRaw commented Nov 11, 2024

Added changelog for 6.3

CHANGELOG.md Outdated
### Resolved issues

- Fixed bandwidth measurement in MI300
- Fix for `s_delay_alu` followed by `s_waitcnt` on gfx11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgopesh What was the exact issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ApoKalipse-V Can you please help Swati with a little more detailed description?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s_delay_alu doesnt generate tokens, so if we had s_delay_alu followed by s_waitcnt, the attribution would be incorrect

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, i`m not sure we should comment on it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, maybe we can generalize by saying Fixing token parsing in ATT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgopesh @ApoKalipse-V So, can I write: Fixed token parsing in ATT for gfx11 where s_delay_alu is followed by s_waitcnt ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that also reveals some details: I would recommend: Fixed token parsing in ATT for gfx11

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not say anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I will remove it.

@bgopesh
Copy link
Collaborator

bgopesh commented Nov 16, 2024

@ammarwa : Do we create any commit directly on public branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants