Update CUDA versions for Python packages #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRit
force-pushed
the
cudaVersion
branch
2 times, most recently
from
d48bb3c to
74fd8ce
Compare
SimonRit
force-pushed
the
cudaVersion
branch
3 times, most recently
from
319c794 to
834cf29
Compare
SimonRit
requested changes
Jan 9, 2026
Collaborator
SimonRit
left a comment
SimonRit
left a comment
There was a problem hiding this comment.
The last commit should be removed from this PR and handled in a separate one IMO. After correcting my inline suggestions, I recommend:
- doing a similar PR in RTKConsortium/RTK
- checking that RTK examples work with newly generated packages as much as possible
- merging the two PRs simultaneously
| matrix: | ||
| python3-minor-version: ${{ github.event_name == 'pull_request' && fromJSON('["11"]') || fromJSON('["9","10","11"]') }} | ||
| cuda-version: ["130"] | ||
| cuda-version: ${{ github.event_name == 'pull_request' && fromJSON('["128"]') || fromJSON('["118","128","130"]') }} |
Collaborator
There was a problem hiding this comment.
11* was intentionally removed, see https://github.com/RTKConsortium/ITKCudaCommon/commits/9f2efd3fd7fb457670e25d01380d13341e81b700/. It would be cleaner to modify the first commit of this pull request with "128","130" and then add the conditional builds in this commit.
| matrix: | ||
| python3-minor-version: ${{ github.event_name == 'pull_request' && fromJSON('["11"]') || fromJSON('["9","10","11"]') }} | ||
| cuda-version: ["124"] | ||
| cuda-version: ["130"] |
Collaborator
There was a problem hiding this comment.
Make it "128","130" in this commit
Version 11.8 is the latest 11 version. Versions 12.8 and 13.0 are aligned with PyTorch.
axel-grc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #88