Skip to content

fix for issue #86 - Possible classpath scanning issues by using XPathFactory.newInstance() #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dfranssen wants to merge 1 commit into
base: release/1.8
Choose a base branch
from
Open

fix for issue #86 - Possible classpath scanning issues by using XPathFactory.newInstance() #87

dfranssen wants to merge 1 commit into from

Conversation

@dfranssen
Copy link

@dfranssen dfranssen commented Dec 8, 2017 •
edited
Loading

fixes #86 - Possible classpath scanning issues by using XPathFactory.newInstance()

@dfranssen dfranssen changed the title fix for issue #86 fix for issue #86 - Possible classpath scanning issues by using XPathFactory.newInstance() Dec 8, 2017
@jhorsman
Copy link
Contributor

jhorsman commented Dec 8, 2017

This PR solves actually solves two things:

  • The classpath scanning issues is prevented by avoiding XPathFactory.newInstance()
  • The DefaultRichTextProcessor no longer uses the XPathResolver which is not thread-safe.

The DefaultRichTextProcessor is now using the new thread-safe and classpath-scanning-proof XPathExpressionResolver instead of the XPathResolver. The XPathResolver should be avoided and is marked as deprecated.

The code in this PR is undergoing load testing and endurance testing on a DXA 1.5 based production environment. I think it is pretty solid :)

rpannekoek pushed a commit that referenced this pull request Feb 2, 2018
Merge pull request #87 in TSI/web-application-java from feature/TSI-3…
1b23f31 
…024 to develop

* commit '1f81792c2f36d500d6bb4bbfd7136ec56ca781db':
  TSI-3025 Removed dxa-compatible and replaced with DD4T dependencies (TSI-3024)
willprice76 pushed a commit to willprice76/dxa-web-application-java that referenced this pull request Apr 10, 2018
@RaimondKempees
Merge pull request RWS#87 from anindita-pal/feature/issue-86-XPMField…
665b1e5 
…Processor-error-for-null-value

Issue 86 Rendering XPM comment for a null field throws exception in thymeleaf tag xpm:field
alebastrov
alebastrov approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@alebastrov alebastrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but are there all possible links listed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alebastrov alebastrov alebastrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dfranssen @jhorsman @alebastrov