Skip to content

Refactors slider #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephenNneji merged 7 commits into from
Nov 27, 2025
Merged

Refactors slider #165

StephenNneji merged 7 commits into from
Nov 27, 2025

Conversation

@StephenNneji
Copy link
Contributor

@StephenNneji StephenNneji commented Nov 27, 2025 •
edited
Loading

  • Refactors slider view so it is created on demand and not held in main view.
  • Decouples the slider view for the project view tables
  • Simplify slider view and revert tests
  • Ensure slider view works properly with undo stack
  • Finally closes Add sliders for parameters #132
  • updated ratapi to dev10

@StephenNneji StephenNneji marked this pull request as ready for review November 27, 2025 13:27
DrPaulSharp
DrPaulSharp approved these changes Nov 27, 2025
View reviewed changes
Copy link
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions.

@StephenNneji StephenNneji merged commit 7e76b2a into RascalSoftware:main Nov 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrPaulSharp DrPaulSharp DrPaulSharp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add sliders for parameters

2 participants

@StephenNneji @DrPaulSharp