Remove macros for unordered maps/sets #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enchufa2
force-pushed
the
feature/unordered
branch
from
020c2cd to
dca5edb
Compare
Member
Author
|
Rebased. |
Used by #1372
Member
|
Rev dep now running with tag 1.0.14.11. |
eddelbuettel
approved these changes
Mar 26, 2025
Member
eddelbuettel
left a comment
eddelbuettel
left a comment
There was a problem hiding this comment.
Nice and clean, should not do damage but let's wait just in case.
(And let's keep in mind that I also skip a few of the more expensive ones...)
Member
|
BTW I think you accidentally mistyped the buttons in the checklist. Hit number two but skip number three? |
Member
Author
|
I did! Fixed. |
eddelbuettel
added a commit
to RcppCore/rcpp-logs
that referenced
this pull request
Mar 28, 2025
Member
|
As anticipated, this too passed without event or issues, more here, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple one. Will rebase and mark as ready for review when #1371 is merged.
Checklist
R CMD checkstill passes all tests