-
Notifications
You must be signed in to change notification settings - Fork 20
Fix error checking documented in Issue #45 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-0.2
Are you sure you want to change the base?
Conversation
|
Can one of the admins verify this patch? |
subpop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think there's a follow-up commit or PR we can introduce here that changes the behavior of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes.
I had the same thoughts as Link when I saw the showErrorMessages method using cli.Exit(), and I would prefer the logic changes to be in a separate small PR instead of this one.
subpop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit linter is failing. 650578b contains a capitalized "Fix". It should be lower-case to conform to Conventional Commits. Do you mind amending the commit and changing the message?
650578b to
8ed081b
Compare
8ed081b to
112b543
Compare
This PR adds checks for the errors potentially returned in a number of places as documented here : #45
This code is not as DRY as I'd like it, all feedback welcome! I hope to solve issues and improve!
Cheers!