chore: Vendor packages on Fedora #335
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-horky
force-pushed
the
mhorky/rawhide-builds
branch
5 times, most recently
from
5e27bfd to
1cf6b95
Compare
Make ignore list more specific by specifying some files are only ignored (or not) when they are in the repository root.
* Card ID: CCT-1886 * Card ID: CCT-1929 This patch adds Makefile to do basic release-related management (like `make archive` to generate tarballs with source code and vendored dependencies). The spec file doesn't use it directly (there was quite a lot of issues caused by shell escaping, as Fedora and RHEL guidelines require packagers to pass relatively complex string with flags to 'go build'; %gobuild does everything for us on the other hand). For now, the 'Makefile' and 'rhc.spec' are expected to target Fedora only; later the spec file will/may be copied to downstream CentOS and RHEL repositories as well. File go-vendor-tools.toml and rhc-VERSION-vendor.tar.bz2 are created by `go_vendor_archive` from @go-sig/go-vendor-tools-dev. Compared to dist/srpm/rhc.spec.in, the handling of systemd timers has been simplified a bit, it doesn't restart daemon and start the timer manually now: > On upgrade, a package may only restart a service if it is > running; it may not start it if it is off. Also, the service may > not enable itself if it is currently disabled. -- Default Services, Fedora Packaging Guidelines [1] The 'rhcd' compatibility layer is disabled for Fedora builds (`%global with_rhcd_compat 0`), but when used downstream, the value can/should be switched to `1` to preserve the behavior. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/ Assisted-By: Claude Code
m-horky
force-pushed
the
mhorky/rawhide-builds
branch
from
1cf6b95 to
b41cdef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Fedora Rawhide/44+ now enforces Go dependency vendorization, update the .spec file to match those requirements.
Also, use the
%gocheck2macro instead of deprecated%gocheck.https://fedoraproject.org/wiki/Changes/GolangPackagesVendoredByDefault
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
This PR does not switch Packit from using the dist/ version of .spec file.