Skip to content

Conversation

@Khem12
Copy link

@Khem12 Khem12 commented May 18, 2025

What are the changes?

The updated dashboard preserves all original interactive features and functionality—including sliders, callbacks, and tabs—while presenting asthma risk visualizations (BMI and lung function) in a more user-friendly format. Key improvements include a simplified layout with larger fonts, clear sectioning, and enhanced spacing for better readability. A prominent display of current oxygen levels is paired with a simple, color-coded gauge and threshold indicators. Actionable advice is provided in bullet points, and emergency information is clearly highlighted in red. Visual cues like emojis and color coding make the information more accessible, while existing features such as epilepsy detection, healthy range comparisons, gauge charts, and time-series analysis remain fully intact.

Who worked on the changes?

  • Khem Raj Gurung

Enhanced Components/Features

  • A big, clear display of current oxygen levels
  • Simple gauge visualization
  • Integrated the asthma risk visualizations (BMI and lung function) in a simplified format
  • Added clear, actionable information with visual indicators (color coding)
  • Organized content into clear sections with larger fonts and better spacing

Other Changes/Fixes

  • Emergency information highlighted in red

  • Example Checkbox

Checklist

  • Existing, relevant documentation has been updated to reflect my changes

Screenshots or example output

Screenshot 2025-05-18 at 8 16 09 PM Screenshot 2025-05-18 at 8 16 19 PM Screenshot 2025-05-18 at 8 16 29 PM Screenshot 2025-05-18 at 8 16 48 PM

@Khem12 Khem12 requested review from a team as code owners May 18, 2025 10:27
@github-actions
Copy link

🔒 Security Scan Results

🔒 Security Scan Results
=========================

Bandit Scan Results:
-------------------
Run started:2025-05-18 10:28:44.745883

Test results:
>> Issue: [B113:request_without_timeout] Call to requests without timeout
   Severity: Medium   Confidence: Low
   CWE: CWE-400 (https://cwe.mitre.org/data/definitions/400.html)
   More Info: https://bandit.readthedocs.io/en/1.8.3/plugins/b113_request_without_timeout.html
   Location: ./data_science/voice_assistant/generate_response.py:14:10
13	def get_request(query):
14	    req = requests.get(f'https://www.google.com/search?q={query}')
15	

--------------------------------------------------
>> Issue: [B404:blacklist] Consider possible security implications associated with the subprocess module.
   Severity: Low   Confidence: High
   CWE: CWE-78 (https://cwe.mitre.org/data/definitions/78.html)
   More Info: https://bandit.readthedocs.io/en/1.8.3/blacklists/blacklist_imports.html#b404-import-subprocess
   Location: ./data_science/voice_assistant/text_to_speech.py:4:0
3	import os
4	import subprocess
5	# Used to get response from user input

--------------------------------------------------
>> Issue: [B607:start_process_with_partial_path] Starting a process with a partial executable path
   Severity: Low   Confidence: High
   CWE: CWE-78 (https://cwe.mitre.org/data/definitions/78.html)
   More Info: https://bandit.readthedocs.io/en/1.8.3/plugins/b607_start_process_with_partial_path.html
   Location: ./data_science/voice_assistant/text_to_speech.py:12:4
11	    time.sleep(2)
12	    subprocess.run(['say', response], check=True)
13	

--------------------------------------------------
>> Issue: [B603:subprocess_without_shell_equals_true] subprocess call - check for execution of untrusted input.
   Severity: Low   Confidence: High
   CWE: CWE-78 (https://cwe.mitre.org/data/definitions/78.html)
   More Info: https://bandit.readthedocs.io/en/1.8.3/plugins/b603_subprocess_without_shell_equals_true.html
   Location: ./data_science/voice_assistant/text_to_speech.py:12:4
11	    time.sleep(2)
12	    subprocess.run(['say', response], check=True)
13	

--------------------------------------------------

Code scanned:
	Total lines of code: 963
	Total lines skipped (#nosec): 0
	Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
	Total issues (by severity):
		Undefined: 0
		Low: 3
		Medium: 1
		High: 0
	Total issues (by confidence):
		Undefined: 0
		Low: 1
		Medium: 0
		High: 3
Files skipped (0):

No critical security issues detected.

The code has passed all critical security checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant