Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/scripts/commitlint-config-maker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ echo ' "subject-empty": [RuleConfigSeverity.Error, "never"] as const,' >> com
echo ' "subject-full-stop": [RuleConfigSeverity.Error, "never", "."] as const,' >> commitlint.config.ts
echo ' "type-case": [RuleConfigSeverity.Error, "always", "lower-case"] as const,' >> commitlint.config.ts
echo ' "type-empty": [RuleConfigSeverity.Error, "never"] as const,' >> commitlint.config.ts
echo ' "type-enum": [RuleConfigSeverity.Error, "always", ["build", "chore", "ci", "docs", "feat", "fix", "perf", "refactor", "revert", "style", "test"]] as [RuleConfigSeverity, RuleConfigCondition, string[]],' >> commitlint.config.ts
echo ' "type-enum": [RuleConfigSeverity.Error, "always", ["build", "chore", "ci", "docs", "feat", "fix", "perf", "refactor", "revert", "style", "test", "merge"]] as [RuleConfigSeverity, RuleConfigCondition, string[]],' >> commitlint.config.ts
echo ' },' >> commitlint.config.ts
echo ' prompt: {' >> commitlint.config.ts
echo ' questions: {' >> commitlint.config.ts
Expand All @@ -32,6 +32,7 @@ echo ' test: { description: "Adding missing tests or correcting existin
echo ' build: { description: "Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)", title: "Builds", emoji: "🛠" },' >> commitlint.config.ts
echo ' ci: { description: "Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)", title: "Continuous Integrations", emoji: "⚙️" },' >> commitlint.config.ts
echo ' chore: { description: "Other changes that don'\''t modify src or test files", title: "Chores", emoji: "♻️" },' >> commitlint.config.ts
echo ' build: { description: "Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)", title: "Builds", emoji: "🛠" },' >> commitlint.config.ts
echo ' revert: { description: "Reverts a previous commit", title: "Reverts", emoji: "🗑" },' >> commitlint.config.ts
echo ' },' >> commitlint.config.ts
echo ' },' >> commitlint.config.ts
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/pr-commitlint.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Pull Request Commit Lint

on: pull_request
on:
pull_request:
branches:
- main
- develop
jobs:
commitlint:
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ let url = URL(string: "http://your.api/post")!

let response = await SNK
.request(url: url)
.jsonContentType()
.body(user)
.post(validateBodyAs: UserResponse.self)

Expand All @@ -79,7 +78,6 @@ let customSNK = SNKSession(
let response =
try await customSNK
.request(path: "/post")
.jsonContentType()
.body(user)
.post(validateBodyAs: UserResponse.self)

Expand Down