Clarify overflow analysis for maxDim-constrained image dimensions #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on PR #280 regarding potential integer overflow in
width * height * getC()expression when checking image dimensions.Analysis
With
maxDim = 65536, the maximum productwidth * heightis4,294,967,296, which fits in 64-bitsize_t. Even with typical channel counts (1-4), the expressionwidth * height * getC()doesn't overflowsize_tbefore theINT_MAXcomparison.Overflow would only occur if:
size_tis 32-bit), ornumChannelsexceeds ~4 millionThe existing check is safe on 64-bit systems with reasonable channel counts. The suggested overflow-safe multiplication approach would add defensive checks that may not be necessary given the
maxDimconstraint, though they would provide additional safety on 32-bit platforms.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.