Address review question on corrupted PFM file handling #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Fix handling of corrupted PFM files in image loaders
Address review question on corrupted PFM file handling
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified behavior when PFM files are corrupted (smaller than header-declared dimensions).
Current behavior
The per-pixel
file.fail()check (line 102) detects truncated files immediately:file.read()sets fail bit when reading beyond EOF"invalid PFM image: error reading pixel data"No code changes needed - the implementation correctly prevents undefined behavior from corrupted files.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.