Add prepatcher attribute and change ResonitePlugin #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazre
requested review from
EIA485,
LeCloutPanda,
NepuShiro,
art0007i and
knackrack615
art0007i
requested changes
Sep 18, 2025
| public ResonitePlugin(string GUID, string Name, string Version, string? Author = null, string? Link = null) : base(GUID, Name, Version, Author, Link) { } | ||
| } | ||
|
|
||
| public class ResonitePrePatcherPlugin : PatcherPluginInfoAttribute |
Contributor
There was a problem hiding this comment.
? that's not how this works
| } | ||
| public string Author { get; protected set; } | ||
| public string Link { get; protected set; } | ||
| public ResonitePlugin(string GUID, string Name, string Version, string? Author = null, string? Link = null) : base(GUID, Name, Version, Author, Link) { } |
Contributor
There was a problem hiding this comment.
if u doing this might as well mark the attribute as [Obsolete]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on ResoniteModding/BepisLoader#20 to be merged. This changes
ResonitePluginto be simply a renamed class and introducesResonitePrePatcherPluginwhich is a renamedPatcherPluginInfoAttributefor consistency sakes. (for backwards compatibility and consistency)The idea is simple.
BepInExResoniteShimshould be the entry point of Resonite BepinEx modding. (it already is, including both CoreCLR and Shim in csproj is pointless unless u want to overwrite CoreCLR version for some reason)Plugin authors should depend on
ResoniteModding.BepInExResoniteShimin the csproj to get the references for BepisLoader (bepinex 6 fork).BepInEx.NET.CoreCLRshould only be used for projects such as Shim itself. This has nothing to do with the Thunderstore package BepInExResoniteShim plugin, so no need to changethunderstore.toml. (even for prepatcher only mods)