-
Notifications
You must be signed in to change notification settings - Fork 35
libretroshare: implement RsGxsWikiEvent and clean dummy code #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libretroshare: implement RsGxsWikiEvent and clean dummy code #228
Conversation
|
Hi you forget to commit the changes for p3wiki.h? it does not compile yet maybe for that needs a new pr next time for implement :) |
src/retroshare/rsevents.h
Outdated
|
|
||
| /// @see RsWireEvent | ||
| SYSTEM = 24, // general system notifications | ||
| GXS_WIKI = 25, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For plugins the event system can allocate a event type dynamically, so that you do not need to modify rsevents.h. Use RsEvent::getDynamicEventType("some string") to get one. Instead of using RsEventTypes::GXS_WIKI, use rsEvents->getDynamicEventType("GXS_WIKI"); (or store the result in a variable).
|
@alvaro-salort we need keep licence header |
f9ea63d to
e427710
Compare
|
git pull --rebase origin master does the trick without merging the remote, but it requires a force push after it, advantage it keeps the git tree easyer to read |
adbbdcf to
465c27f
Compare
|
Great PR. Just fix my comment above about the flags and we'll merge it. |
465c27f to
cb57e66
Compare
All done! I hope I have understood the instructions correctly. Sorry for the delay, I hope this is the final attempt. |
|
Thanks for your guidance! it was a good experience 🦊❤️ |
Implemented rsEvents for the Wiki service to allow real-time UI updates.
Removed legacy dummy code and unused tick events from 2012.
Matches the architecture of GxsChannels.