feat: minor fixes and improvements to the UI #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robertmarsal
commented
Oct 3, 2025
robertmarsal
commented
- Consistent Headers for Dialogs
- Removed extra verbose logging
- Display SDK version in the about dialog
- Don't automatically open the log window after attaching to an existing analysis (the analysis is already done there's no need to check the logs)
brettwold
approved these changes
Oct 3, 2025
fmagin
reviewed
Oct 3, 2025
Comment on lines
67
to
69
| // We don't need to display the log window when the user selects an existing analysis because it will be an | ||
| // already completed analysis. | ||
| if (event.getSourceName().equals("Recent Analysis Dialog")) { |
Collaborator
There was a problem hiding this comment.
I would not say this is strictly true, they might be attaching to an analysis they started on the portal that hasn't finished yet? Seems more appropriate and less brittle to me to check for the status inside the event instead, because that's closer to the actual intent
Collaborator
There was a problem hiding this comment.
Arguably, with the new function boundaries this is highly unlikely to be an analysis from the portal
Contributor
Author
There was a problem hiding this comment.
A while back in one of my other PRs I also limited the list of analyses a user can attach to, to complete ones so they shouldn't be able to attach to partially completed analyses any longer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.