Fix return type annotations for train functions to include best_epoch #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Update code cleanup and docstrings based on PR review feedback
Fix return type annotations for train functions to include best_epoch
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type annotations for
train()andtrain_model_from_config()were incomplete, declaring only 3 elements while the functions actually return 4 (includingbest_epoch). The docstrings were already correct.Changes:
train()return type:tuple[eqx.Module, list, list]→tuple[eqx.Module, list, list, int]train_model_from_config()return type:tuple[eqx.Module, list, list]→tuple[eqx.Module, list, list, int]Both functions return
(model, train_losses, val_losses, best_epoch)wherebest_epochtracks the epoch with the lowest validation loss.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.