Bugfixes #4
Open
Bugfixes #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$employeeNumber = 1 was missing.
If a user existed, $employeeNumber = $employeeNumber+1 was never reached and $sAMAccountName = $orgShortName + $employeeNumber would never change causing it to loop through all names, not adding a single one.
Changed to always +1 in the name list for when adding a much smaller amount (say 10 users) give all fake users different first names.
script's and not scripts
Owner
|
$employeeNumber fix is already implemented, and Spelling fix would be gramatically incorrect. |
Owner
|
Totally didnt forget about this repo. Better late than never i guess 😇 |
RobBridgeman
requested changes
Nov 13, 2018
Owner
RobBridgeman
left a comment
RobBridgeman
left a comment
There was a problem hiding this comment.
All credits to the script's original creator. = All credits to the script is original creator.
RobBridgeman
requested changes
Nov 13, 2018
Owner
RobBridgeman
left a comment
RobBridgeman
left a comment
There was a problem hiding this comment.
Already implemented from original script. Please see Master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$employeeNumberwas never initiated, added that.If running the script once and then running it again, the user would exist and it would continue and loop through all names without adding anything. Fixed that by adding
$employeeNumber = $employeeNumber+1before the continue statement.