Skip to content

Conversation

@Anxhul10
Copy link
Contributor

@Anxhul10 Anxhul10 commented May 7, 2025

Summary

This PR integrates the Button component into the fuselage-tamagui package and includes several improvements and fixes.

Changes Made

  • Replaced hardcoded colors in Button with token-based values from tamagui.config.ts.
  • Fixed multiple TypeScript errors across the package.
  • Used webpack (instead of vite as originally proposed) to align with the existing Fuselage setup and avoid introducing new dependencies.

ScreenRecording

Screencast.from.2025-05-08.04-24-01.mp4

Notes

Although the initial proposal mentioned using vite, this PR uses webpack for compatibility with the existing Fuselage architecture and to reduce dependency overhead.

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: d8dec88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Anxhul10 Anxhul10 changed the title PoC: Implement Tamagui with Button Styling & Webpack Setup (WIP) fix: Implement Tamagui with Button Styling & Webpack Setup (WIP) May 7, 2025
@Anxhul10 Anxhul10 changed the title fix: Implement Tamagui with Button Styling & Webpack Setup (WIP) fix: POC Implement Tamagui with Button Styling & Webpack Setup (WIP) May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant