Skip to content

Conversation

@ditoglez
Copy link
Contributor

@ditoglez ditoglez commented Sep 6, 2018

WIP: Adds dynamic-table module
@flore2003, @erzaehlsalex let's see what else we can do here.

Closes #6

@ditoglez ditoglez added the enhancement New feature or request label Sep 6, 2018
@ditoglez ditoglez force-pushed the enhancement/6 branch 2 times, most recently from 8bfd873 to 09c3d67 Compare September 7, 2018 08:41
@ditoglez ditoglez changed the title enhancement/6 - add dynamic-table module feat(dynamic-table): introduce dynamic-table module Sep 7, 2018
@ditoglez ditoglez force-pushed the enhancement/6 branch 21 times, most recently from 7db4c80 to ea73422 Compare September 10, 2018 11:50
@ditoglez ditoglez force-pushed the enhancement/6 branch 2 times, most recently from 5869f08 to cc792b5 Compare September 12, 2018 08:09
@ditoglez
Copy link
Contributor Author

@flore2003, I think we have to review this codeclimate stuff 🤣

@mbeckenbach
Copy link

@flore2003 @erzaehlsalex
Had a look at the codeclimate results. This does not seam to be important. It's only complaining that we have similar code blocks in the unit test test data. Is it really necessary to fix these?

image

@mbeckenbach
Copy link

Found some Errors that webstom marks as build errors:

image

Could be resolved by adding Observable to the imports like described here:
https://stackoverflow.com/questions/54145091/public-property-x-of-exported-class-has-or-is-using-name-observable-from-exter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Component/Service] Dynamic Table Component

5 participants