Skip to content

feat(number-input): introduce number-input module #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ditoglez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(number-input): introduce number-input module #4

ditoglez wants to merge 1 commit into from

Conversation

@ditoglez
Copy link
Contributor

@ditoglez ditoglez commented Sep 3, 2018 •
edited
Loading

Adds number-input module to the library, unit tests.

Closes #2

@ditoglez ditoglez added the enhancement New feature or request label Sep 3, 2018
@ditoglez ditoglez changed the title enhancement/number-input-component - add number-input component to the lib enhancement/2- add number-input component to the lib Sep 3, 2018
@flore2003
Copy link
Member

flore2003 commented Sep 5, 2018

See discussion in #2
We also need to rebase this onto master 🙂

ditoglez pushed a commit that referenced this pull request Sep 6, 2018
enhancement/4 - add dynamic table module
c4ff88f 
Closes #4
@flore2003
Copy link
Member

flore2003 commented Sep 7, 2018 •
edited
Loading

Is there a good reason we are copying the testing utilities from angular/material2? Can we not just use the @angular/cdk package to include the testing utilities in our library?

@flore2003
Copy link
Member

flore2003 commented Sep 7, 2018

@ditoglez This also still has the rp prefix, we should update this to reflect the new ngr prefix. I also changed the default style to 4 spaces instead of 2, we should update all open pull requests to reflect this.

ditoglez pushed a commit that referenced this pull request Sep 7, 2018
enhancement/4 - add dynamic table module
cee84b8 
Closes #4
@ditoglez ditoglez force-pushed the enhancement/2 branch 3 times, most recently from 45da85e to fa02d35 Compare September 7, 2018 09:12
@ditoglez ditoglez changed the title enhancement/2- add number-input component to the lib feat(number-input): introduce number-input module Sep 7, 2018
flore2003
flore2003 requested changes Sep 7, 2018
View reviewed changes
Copy link
Member

@flore2003 flore2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this PR and solve the conflicts it has with master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flore2003 flore2003 flore2003 requested changes

@erzaehlsalex erzaehlsalex Awaiting requested review from erzaehlsalex

Assignees

@flore2003 flore2003

@erzaehlsalex erzaehlsalex

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ditoglez @flore2003 @erzaehlsalex