-
Notifications
You must be signed in to change notification settings - Fork 32
Changes to github workflows #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-Authored-By: Debug <49997488+debugok@users.noreply.github.com>
|
Note: Schema validators failing is unrelated. Should maybe consider turning them off too while those are broken upstream. |
| - name: Generate Changelog | ||
| run: | | ||
| cd "Tools/changelog" | ||
| node changelog.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is calling a script that we don't actually have, as far as I can tell. See DeltaV-Station/Delta-v#11 having added Tools/Changelogs/changelog.js
| types: [closed] | ||
|
|
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.BOT_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have these secrets set up? I'm not 100% on where they're supposed to be stored.
arenaconspiracy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally pressed "single comment" instead of starting a review on prior comments, whoops. They're there though.
|
Converted to a draft until secrets and vars are worked out |
About the PR
Made changes we'd been talking about to publish workflows and added changelog.yml (ripped from deltav) workflow file to make changelogs easier.
Why / Balance
I wish to put an end to @arenaconspiracy's suffering
Technical details
Media
Requirements
Breaking changes
Changelog
🆑