minimal-versions: modify root workspace instead of replacing it #54
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
commented
Jan 21, 2026
| EOF | ||
| - name: Remove other members from the workspace | ||
| run: sed -z -E | ||
| "s/members = \\[([A-Za-z0-9_,-]|\"|\\n|\\s)*\\]/members = [\"${{ inputs.working-directory }}\"]/g" |
Member
Author
There was a problem hiding this comment.
My regexp-fu is far from the master level, so this expression can be probably simplified and/or made more precise.
Member
Author
|
Note that unused patches can result in warnings on |
tarcieri
approved these changes
Jan 21, 2026
Member
|
Of course right when I stamp it there's a build failure, heh https://github.com/RustCrypto/hashes/actions/runs/21214764058/job/61034425331?pr=773 |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing it preserves other workspace settings such as lints, patches, and build profiles. Notably, it means that we no longer need to disable minimal-versions jobs when temporary patching is used.
The new config is tested in RustCrypto/hashes#773