Skip to content

Conversation

@newpavlov
Copy link
Member

As was discussed here.

@newpavlov newpavlov requested a review from tarcieri January 30, 2026 15:43
@tarcieri
Copy link
Member

Sidebar: seems like this check should be constant-time?

@newpavlov
Copy link
Member Author

newpavlov commented Jan 30, 2026

seems like this check should be constant-time?

In practice it gets compiled to const-time code (godbolt) and this is why I bothered with using u64 instead of comparing arrays directly, but I am not sure that we can say that it's guaranteed. For it we would need to add optimization barriers to is_weak.

@newpavlov newpavlov merged commit 4870153 into master Jan 30, 2026
10 checks passed
@newpavlov newpavlov deleted the des/weak_key branch January 30, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants