polyval: consolidate single PolyvalGeneric struct
#276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
polyval/consolidate-uhf-type
branch
from
c668d07 to
030ef72
Compare
Consolidates the many (nested, via unions!) repeated `Polyval` structs found throughout the crate for each backend into a single `Polyval(Generic)` struct which imlements the `universal-hash` interface in a single place. `FieldElement` now defers decoding into SIMD registers until we're ready to actually perform a field operation, so we can use that as a common type for all field backends (and already implemented this in previous commits). Backends are now just free functions that operate on `FieldElement`, making them dramatically simpler.
tarcieri
force-pushed
the
polyval/consolidate-uhf-type
branch
from
030ef72 to
cc9faff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates the many (nested, via unions!) repeated
Polyvalstructs found throughout the crate for each backend into a singlePolyval(Generic)struct which imlements theuniversal-hashinterface in a single place.FieldElementnow defers decoding into SIMD registers until we're ready to actually perform a field operation, so we can use that as a common type for all field backends (and already implemented this in previous commits).Backends are now just free functions that operate on
FieldElement, making them dramatically simpler.