polyval: use intrinsics when computing powers of H
#277
+53
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only time we actually use powers-of-`H` is when we have intrinsics anyway, so we might as well make use of the intrinsics when computing them. This factors the computation into the `autodetect` module with autodetection support and a fallback to a stub implementation for the `soft` backend which only initializes and access the last element (which is layout-compatible with the intrinsics implementation, if we ever decide to add the requisite support to the soft backend)
Member
Author
|
Note: this more or less fixes a regression during refactoring where the soft backend wound up being what computed these. We previously had support for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only time we actually use powers-of-
His when we have intrinsics anyway, so we might as well make use of the intrinsics when computing them.This factors the computation into the
autodetectmodule with autodetection support and a fallback to a stub implementation for thesoftbackend which only initializes and access the last element (which is layout-compatible with the intrinsics implementation, if we ever decide to add the requisite support to the soft backend)