polyval: expose FieldElement under hazmat feature
#279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `hazmat` feature and conditionally adds a `pub` re-export of the `FieldElement` type under a new `hazmat` module. All of its inherent methods are still private, so this just exposes the trait impls backed by the `soft` implementation. We will probably need to expose some things like `InitToken` and functions like `polymul` that accept it and select between intrinsics/soft implementations to enable performance-oriented usage of this type, which is why it's being placed in a `hazmat` module where we can potentially put some of the other things that would actually make it useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
hazmatfeature and conditionally adds apubre-export of theFieldElementtype under a newhazmatmodule.All of its inherent methods are still private, so this just exposes the trait impls backed by the
softimplementation.We will probably need to expose some things like
InitTokenand functions likepolymulthat accept it and select between intrinsics/soft implementations to enable performance-oriented usage of this type, which is why it's being placed in ahazmatmodule where we can potentially put some of the other things that would actually make it useful.