Update CI FHiCLs in develop branch #874
Conversation
cerati
left a comment
cerati
left a comment
There was a problem hiding this comment.
overall looks good to me -- it matches what we have developed and tested jointly. I think the overrides in test/ci/icarus_ci_intimecosmic_g4_quick_test_icaruscode.fcl are redundant with respect to those in upstream files and should be removed for simplicity.
good point, removed these overrides. |
SFBayLaser
left a comment
SFBayLaser
left a comment
There was a problem hiding this comment.
I am afraid I am not expert at the changes at the larg4 stages which look to be the key to fixing the issues. I take it on faith that these have been shown to fix the problem so I am happy to ahead and approve this.
gputnam
left a comment
gputnam
left a comment
There was a problem hiding this comment.
I am not very familiar with the intime workflow and cannot speak to those updates in depth. Everything else looks good to me.
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
This PR is to update the set of FHiCL files used by the CI for the three MC workflow we currently test with the CI, these are:
This also update some standard FHiCL to update them with current code.
With this PR we should be able to run regression test for the develop branch.