Skip to content

Conversation

@bear-is-asleep
Copy link
Contributor

Description

Fix booleans in from new MultiPart Generators

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • [na] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • [na] Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Dependent on LArSoft/larsim#162, then SBNSoftware/sbncode#594. Once these are merged you can merge this. For now, I will keep as a draft

@bear-is-asleep bear-is-asleep self-assigned this Oct 23, 2025
@bear-is-asleep bear-is-asleep added the bug Something isn't working label Oct 23, 2025
@nathanielerowe nathanielerowe marked this pull request as ready for review November 19, 2025 18:43
@nathanielerowe nathanielerowe moved this to Waiting on Reviewer in SBND 2025 Fall Production Nov 19, 2025
@nathanielerowe
Copy link
Contributor

@justinjmueller is this good to go too?

Copy link

@justinjmueller justinjmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(sorry I missed this yesterday)

@nathanielerowe nathanielerowe moved this from Waiting on Reviewer to Reviewer Approved in SBND 2025 Fall Production Nov 20, 2025
@nathanielerowe
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

Approved

@nathanielerowe nathanielerowe moved this from Reviewer Approved to RM Approved in SBND 2025 Fall Production Nov 21, 2025
@nathanielerowe nathanielerowe merged commit ff12f23 into develop Nov 21, 2025
@nathanielerowe nathanielerowe moved this from RM Approved to In tagged release in SBND 2025 Fall Production Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

5 participants