Created svg files for all icons #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDesya74
requested changes
Jul 30, 2024
Owner
SDesya74
left a comment
SDesya74
left a comment
There was a problem hiding this comment.
Ещё я подумал, наверное лучше все файлы назвать без Icon в конце, и так понятно что иконки, потому что svg
| </svg> | ||
| <button | ||
| class="w-4 h-4 absolute right-2 top-2" | ||
| title="Drag & move" |
Owner
There was a problem hiding this comment.
Лучше "Move note", тайтл должен описывать, что кнопка делает
| </div> | ||
|
|
||
| <svg | ||
| class="fill-current w-8 h-8" |
Owner
There was a problem hiding this comment.
А разве классы указанные в svg заработают в Tailwind? По-моему их лучше оставить на кнопке
| width="16" | ||
| height="16" | ||
| fill="currentColor" | ||
| class="bi bi-copy" |
Owner
There was a problem hiding this comment.
Ето можно удалить тут и в остальных файлах, строка ничего не делает, классов таких у нас нет
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.