Sort on related columns from inventory list #5142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
added
the
Feature
perryr16
changed the title
Contributor
Author
|
The failing test should be addressed by PR #5146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Sorting has previously been disabled for related columns on the inventory list ui-grid
What's this PR do?
_parse_view_sort/build_view_filters_and_sortsnow recognize columns that live on the related inventory (tax-lot fields on the property grid, or vice versa). When you sort on one of those columns, we build a per-record value from the related join and hand it back to the queryset, so the backend actually honors the sort order instead of ignoring it. For string-y related fields we run the value through the same “natural sort” treatment as first-party columns, which keeps mixed numeric strings in human order (1, 2, 10 instead of 1, 10, 2).Added tests
How should this be manually tested?
Upload taxlots and properties, sort on related fields
What are the relevant tickets?
#5088
Screenshots (if appropriate)