@W-11993356 Metecho: handle scratch org DNS propagation delays

[jofsky]

No description provided.

[prescod]

I'm not a big fan of formatting changes being mixed into the same PR as logic changes.

Are you using a different version of black than the one that was used the last time these files were touched?

Other changes inline.

[prescod]

Suggested change

	if total_wait_time >= settings.MAXIMUM_JOB_LENGTH:
	raise ScratchOrgError(
	f"Failed to build your scratch org after {settings.MAXIMUM_JOB_LENGTH} seconds."
	assert total_wait_time >= settings.MAXIMUM_JOB_LENGTH:
	raise ScratchOrgError(
	f"Failed to build your scratch org after {settings.MAXIMUM_JOB_LENGTH} seconds."

[prescod]

I didn't realize that the project wasn't already using responses.

We should decide if we are actually planning to use responses more generally. Adding it to the project trigger a single exception is probably overkill. One line of mocking could achieve the same thing.

Adding the one line of mocking is probably clearer anyways.

Let's just find out what Requests code is calling the Responses code and throw an exception in it.

[prescod]

I could approve as-is but if we have time to make these changes then let's do it.