Skip to content

[PR]User Authentication #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kkho9654 wants to merge 52 commits into
base: main
Choose a base branch
from
Open

[PR]User Authentication #68

kkho9654 wants to merge 52 commits into from

Conversation

@kkho9654
Copy link
Contributor

@kkho9654 kkho9654 commented May 8, 2024

name: User Authentication

Name about title labels assignees
User Authentication User Authentication "[PR]User Authentication" PR @kkho9654

작업 내용:

  1. 사용자 인증
  • id, pw 로그인을 통한 인증 => JsonAutentication~~
  • JWT 토큰을 통한 인증 => JWT~
  1. 사용자 인증 흐름
  • 인증되지 않은 사용자는 일단 로그인, 회원가입, 토큰 재발급만 가능
  • 아이디 패스워드 요청으로 로그인으로 사용자 인증 가능
  • 아이디 패스워드 인증 후 리프래시 토큰(http-only cookie), 엑세스 토큰 발급
  • JWT토큰은 헤더의 Authorization: Bearer {액세스 토큰} 을 검사해서 인증
  1. swagger에 token으로 인증 가능
  • 회원가입 -> 로그인 -> 액세스토큰 발급 -> "Bearer "+ access token 을 swagger-ui/index.html의 우측상단 authorize에 넣기

이번에 공들였던 부분:

  1. 일단 스프링 시큐리티에 대한 이해 부족으로 공부하면서 하느라 조금 오래걸렸다
  2. 인증 흐름에 대해 정확히 알지 못해서인지 계속 수정하느라 오래걸림
  3. 테스트 코드 작성하기 너무 빡세다.... 죄송합니다. (swagger로 통합테스트 계속 해보긴 했습니다)

질문:

제출 전 필수 확인 사항:

  • 빌드가 되는 코드인가요?
  • 버그가 발생하지 않는지 충분히 테스트 해봤나요?

kkho9654 added 30 commits April 21, 2024 10:39
@kkho9654
Feat: SecurityUser implements UserDetails
dcd55a7
@kkho9654
Feat: UserDetailService
5c21b5c
@kkho9654
Feat: jwt token entity, 발급자, security key
9bbadb0
@kkho9654
Feat: jwt token provider
6fe82e4
@kkho9654
Feat: UserAuthenticationProvider for login
aa2c801
@kkho9654
Feat: refresh token
86a6902
@kkho9654
Feat: jwt authentication filter
c09eff3
@kkho9654
Feat: security config
c2661f7
@kkho9654
➕Chore: jwt dependency
2d5e164
@kkho9654
✨Feat: jwt application properties
35cbcbb
@kkho9654
✨Feat: BCryptPasswordEncoder bean
e4dfd5a
@kkho9654
♻️Refactor : User addresses column 삭제
a559ab7
@kkho9654
➕ Chore: jwt & security dependency
c1e65aa
@kkho9654
✨ Feat: JwtToken Provider
620d806
@kkho9654
✨ Feat: RefreshToken entity
126e60b
@kkho9654
✨ Feat: JWT AuthenticationFilter
1f7b847
@kkho9654
✨ Feat: User Authentication
269aa51
@kkho9654
✨ Feat: User Details Service
3a9cb02
@kkho9654
✨ Feat: Security Configuration
e5fea96
@kkho9654
💩
c8240fc
@kkho9654
✨Feat: Authentication Controller
89340d0 
- login
- token
@kkho9654
✨Feat: Authentication Service
348b2ea 
- provide access token
@kkho9654
🎨 Rename: Authentication package structure
9be0672
@kkho9654
🥅 Feat: InvalidTokenException
7d8c6c0
@kkho9654
♻️ Style: remove print, unused dependency
603126b
@kkho9654
♻️ Style: remove print, unused dependency
7677e0f
@kkho9654
⚰️ Refactor: move login logic User to Auth
e795e40
@kkho9654
♻️ Refactor: User table name
19c93fa
@kkho9654
✨ Feat: Auth token DTO
919cfd9
@kkho9654
🔧 Feat: security configuration
21f0e67
kkho9654 added 21 commits April 28, 2024 06:23
@kkho9654
remove: .gitkeep
accca65
@kkho9654
🎨 Refactor: refresh token 을 http only cookie에 넣는다.
a5c3e68 
- 기존 : body로 반환
@kkho9654
✅ Test: UserService Unit Test
17a93ed
@kkho9654
🐛 Fix: Auth login request
e2cb3f9
@kkho9654
✨ Feat: swagger authentication
3d9c295
@kkho9654
♻️ Refactor: user, address entity
a25d7e7 
- 유저, 주소간 1대N관계에 Lazy fetch 추가
- 유저 정보 불러왔을 때 주소의 유저정보까지 나오는 버그
- 유저 createdAt추가
@kkho9654
♻️ Feat: user createdAt
94b4382
@kkho9654
🎨 Feat: user authority via user type
85f5408
@kkho9654
♻️ Refactor: user update controller, service method include id
1491c1c
@kkho9654
🔇 Delete: println
85fd6e4
@kkho9654
🐛 Fix: 권한이 없을 때 default buyer 권한
4d9a261
@kkho9654
🐛 Fix: User mapper 를 위한 setter
c723ed1
@kkho9654
🎨 Fix: 유저 삭제시 관련 refresh토큰 삭제
16a4681
@kkho9654
🎨 Fix: 유저 email update 불가능
5e4a39a
@kkho9654
🎨 Refactor: user id Long to UUID
cc737ee
@kkho9654
🐛 Fix: password encode when updating
856e362
@kkho9654
✅ Test: update user service test
4074a16 
- id long to UUID
@kkho9654
🔥 Refactor: unused success handler
7ba3477
@kkho9654
♻️ Refactor: UsernamePasswordAuthenticationFilter
4639c4e 
- setPasswordParameter 메소드 사용
- JsonProcessingAuthenticationException custom exception
- 컨텐트 타입 체크 : equals->startWith
- try-with-resources
@kkho9654
🎨 Feat: 생성자
09f3b80
@kkho9654
📝 Docs: 인증 관련 java docs
88a149c
@kkho9654 kkho9654 added the PR label May 8, 2024
@kkho9654 kkho9654 self-assigned this May 8, 2024
wintiger98
wintiger98 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@wintiger98 wintiger98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swagger 테스트 상 문제 없네요. 확인했습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wintiger98 wintiger98 wintiger98 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@kkho9654 kkho9654

Labels

PR

Projects

SSapingMall Kanban
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkho9654 @wintiger98