-
Notifications
You must be signed in to change notification settings - Fork 5
Create brainrpg.md #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi there! Thanks very much for the pull request. I've added a template for streamer Markdown files that can be found here. Can you make sure it conforms to the template, if that is OK (I've highlighted the lines that need to be changed)? Also, would you mind creating a new issue for the Julia Streamers collective, providing information on them such as logo etc., so that I make sure to add them to the site as a collective? Thanks. |
| sciences: | ||
| - mathematics | ||
| - physics | ||
| - computer science |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace the space with a dash, please?
| twitch: | ||
| url: https://www.twitch.tv/BrainRPG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the url: key and move the URL over to twitch:, please? Thanks.
| - physics | ||
| - computer science | ||
| collectives: | ||
| - JuliaStreamers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you lowercase this, please?
|
Hi @miguelraz Just an update. The repo has undergone many changes since this PR was first opened. I have updated the streamer file, and my changes can be seen on https://raw.githubusercontent.com/STEMLive/stemlive.github.io/patch-1/models/_educators/brainrpg.md Can you please compare this to https://raw.githubusercontent.com/STEMLive/stemlive.github.io/master/models/templates/EDUCATOR.md, and see what other changes you would like to implement? Otherwise, you should just be able to merge my changes on the patch-1 branch into yours and update the PR. |
|
@ArunSahadeo , thank you so much for you response, follow up, and patience. I hope this PR hasn't staled too bad - should I still try and merge this commit to the patch-1 branch? I might need some git-foo handholding to do so 😅 . I would be glad to add the JuliaStreamers org info, I will open up an issue for that. Thank you again for all the work you do! |
|
Hello @ArunSahadeo , any chance this can get rebased? |
|
Bump! |
No description provided.