Skip to content

Conversation

@miguelraz
Copy link

No description provided.

@ArunSahadeo
Copy link
Collaborator

ArunSahadeo commented Jul 9, 2020

Hi there!

Thanks very much for the pull request.

I've added a template for streamer Markdown files that can be found here.

Can you make sure it conforms to the template, if that is OK (I've highlighted the lines that need to be changed)?

Also, would you mind creating a new issue for the Julia Streamers collective, providing information on them such as logo etc., so that I make sure to add them to the site as a collective?

Thanks.

sciences:
- mathematics
- physics
- computer science
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the space with a dash, please?

Comment on lines +14 to +15
twitch:
url: https://www.twitch.tv/BrainRPG
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the url: key and move the URL over to twitch:, please? Thanks.

- physics
- computer science
collectives:
- JuliaStreamers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you lowercase this, please?

@ArunSahadeo
Copy link
Collaborator

Hi @miguelraz

Just an update.

The repo has undergone many changes since this PR was first opened.

I have updated the streamer file, and my changes can be seen on https://raw.githubusercontent.com/STEMLive/stemlive.github.io/patch-1/models/_educators/brainrpg.md

Can you please compare this to https://raw.githubusercontent.com/STEMLive/stemlive.github.io/master/models/templates/EDUCATOR.md, and see what other changes you would like to implement? Otherwise, you should just be able to merge my changes on the patch-1 branch into yours and update the PR.

@miguelraz
Copy link
Author

@ArunSahadeo , thank you so much for you response, follow up, and patience.

I hope this PR hasn't staled too bad - should I still try and merge this commit to the patch-1 branch? I might need some git-foo handholding to do so 😅 .

I would be glad to add the JuliaStreamers org info, I will open up an issue for that.

Thank you again for all the work you do!

@miguelraz
Copy link
Author

Hello @ArunSahadeo , any chance this can get rebased?

@miguelraz
Copy link
Author

Bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants