Fix APIfeature.traps.paint() can't get
#961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaterArc
approved these changes
Nov 28, 2024
rgantzos
approved these changes
Nov 30, 2024
rgantzos
added
type: enhancement
rgantzos
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment, the paint editor feature wasn't working, and upon investigating the cause, I noticed that feature.traps.paint() was returning null. Further investigation revealed that the class name for the paint editor's mode selector had changed from
paint-editor_mode-selector_28iiQtopaint-editor_mode-selector_O2uhP. As a result, I updated the code to search for the new class name when the element with the old class namepaint-editor_mode-selector_28iiQcouldn't be found. At least in my environment, this issue has been resolved.