Skip to content

Conversation

@mbencer
Copy link
Contributor

@mbencer mbencer commented May 8, 2025

This commit adds recipes and test rules for checking correctness of resizing.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com

Issue: #14791
Draft: #14727

This commit adds recipes and test rules for checking correctness of resizing.

ONE-DCO-1.0-Signed-off-by: Mateusz Bencer m.bencer@partner.samsung.com
@mbencer mbencer requested review from mhs4670go and seanshpark May 8, 2025 11:15
@mbencer mbencer added the PR/NO MERGE Please don't merge. I'm still working on this :) label May 8, 2025
@mbencer mbencer removed the PR/NO MERGE Please don't merge. I'm still working on this :) label May 12, 2025
@seanshpark seanshpark requested review from jinevening and removed request for seanshpark May 12, 2025 21:37
@seanshpark
Copy link
Contributor

I cannot confirm this PR as I don't understand the numbers of the validation.
Please get from @jinevening as he reviewed circle-resizer tool.

Copy link
Collaborator

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbencer mbencer requested a review from seanshpark May 14, 2025 12:32
@seanshpark seanshpark removed their request for review May 14, 2025 21:10
@seanshpark seanshpark merged commit 0d0ffe0 into Samsung:master May 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants