pull new version #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup event bindings when reinitialized - There was a race-condition that caused this plugin to get cleanup and never reinitialized in certain cases which meant that timeout errors were not consistently triggered in situations where the browser was performing slowly.
* Error if Flash tech is unusable * Return early if there already is an error * Added clarifying comments
This reverts commit 9b966f6.
* Allow errors to be non-dismissible * Consolidate error display and dismiss as default * Refactor dismiss and add unit tests * Refactor dismiss - Attach to modalclose event for player.error(null) - Remove double-binding of the closeButton - Remove disposal of child closeButtons before closeable - Attach to okButton on player rather than videojs * Add unit tests for dismiss * Update README.md - dismiss can be passed along with custom error - Default errors on iPhone no longer appear dismissible * Make closeable more clear * Build innerHTML string in separate variable
* update travis to test 5 & 6 * make queries local to errorDisplay rather than document
…clone them to more correct language codes (#176)
When in the background, timers are throttled, so, we want a higher player timeout threshold. Our new default for background timeout is 5 minutes. Background timeout can be disabled entirely by setting the value to Infinity. It is also turned off if the player is playing muted.
* plugin update + unit test * update readme * timeout update + unit test * move muted condition * update nvmrc * indexOf update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.