Skip to content

Refactor #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amab8901 wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Refactor #17

amab8901 wants to merge 13 commits into from

Conversation

@amab8901
Copy link
Collaborator

@amab8901 amab8901 commented Oct 9, 2023 •
edited
Loading

Solves:
https://worldmobile.atlassian.net/browse/EN-491

Description:

  • fix typo "deligator" -> "delegator"
  • replace placeholder values with todo!() macro
  • replace src/x/mod.rs with src/x.rs

issokuos
issokuos reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@issokuos issokuos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intend of this PR if to fix typos, then we should address all the typos in the files changed.

issokuos
issokuos requested changes Oct 13, 2023
View reviewed changes
src/provider.rs
}

async fn deligations_per_pool_epoch_intervall(
async fn delegations_per_pool_epoch_intervall(
Copy link
Collaborator

@issokuos issokuos Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename "intervall" to "interval" as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@issokuos issokuos issokuos requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amab8901 @issokuos