feat(php): release of PHP 8.5.0 #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frzk
requested review from
a team and
EtienneM
and removed request for
a team
EtienneM
previously approved these changes
Nov 24, 2025
Member
EtienneM
left a comment
EtienneM
left a comment
There was a problem hiding this comment.
Just one question. Already approving
support/package_all
Outdated
| # IMAP extension has been moved to PECL starting with PHP 8.4 | ||
| # https://www.php.net/ChangeLog-8.php#8.4.1 | ||
| if [[ "${ext_name}" == "imap" ]] \ | ||
| && [[ "${php_version}" == "8.4" || "${php_version}" == "8.5" ]] |
Member
There was a problem hiding this comment.
suggestion: would it be possible to write something like:
Suggested change
| && [[ "${php_version}" == "8.4" || "${php_version}" == "8.5" ]] | |
| && [[ "${PHP_MODULE_API_VERSIONS["$php_series"]}" -ge 20240924 ]] |
That way we wouldn't forget to update this for the next major release
EtienneM
reviewed
Nov 25, 2025
support/package_all
Outdated
Comment on lines
18
to
19
| #cur_dir="$( dirname -- "${BASH_SOURCE[0]}")" | ||
| #source "${cur_dir}/../conf/versions.sh" |
Comment on lines
+27
to
+38
| # SKIP imap extension since it has been moved to PECL starting with PHP 8.4 | ||
| # https://www.php.net/ChangeLog-8.php#8.4.1 | ||
| # | ||
| # SKIP amqp extension since it doesn't compile with PHP 8.5 | ||
| # https://github.com/php-amqp/php-amqp/pull/595 | ||
| # | ||
| # SKIP igbinary extension since it doesn't compile with PHP 8.5 | ||
| # https://github.com/igbinary/igbinary/issues/400 | ||
| # | ||
| # SKIP imagick extension since it doesn't compile with PHP 8.5 | ||
| # https://github.com/Imagick/imagick/issues/755 | ||
| # |
Member
There was a problem hiding this comment.
praise: thanks for the comment 🙏
Following review :)
EtienneM
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #551