-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
git(-with-openssh): Improve registry srcipt & relevant logic, update checkver & autoupdate #7459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All changes look good. Wait for review from human collaborators. git-with-openssh
git
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. git-with-openssh
git
|
|
Hello, @Lutra-Fs . The previously mentioned license issue has been resolved. Are there any other concerns with this PR? Is there anything I can do to help expedite the review process? |
Apologies for the late reply. I'm currently tied up with other matters, but I'll take another look at your PR and get back to you as soon as I can. |
Lutra-Fs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are available, when addressing these comments, pls also submit your verification script, and results.
Best Regards.
|
/verify |
|
All changes look good. Wait for review from human collaborators. git-with-openssh
git
|
…checkver & autoupdate
|
/verify |
|
All changes look good. Wait for review from human collaborators. git-with-openssh
git
|
Thank you for reviewing this pull request. All comments have been addressed. I have also rechecked all files containing changes and should be clear of any further issues. |
|
Hello, @Lutra-Fs . Sorry for the late reply.
|
|
Will get these done tomorrow. Currently feeling a bit burned out, there’s just too much going on in my life right now ;; |
|
You only need to take a look when you have time. Please make sure to get enough rest — your health is the most important thing. Thank you again for taking the time to review my PR. ❤️ |
Summary
Improves the
gitandgit-with-opensshmanifests by refining metadata, restructuring post-install behavior, modernizing registry script handling, and aligning both packages with Scoop manifest conventions.Related issues or pull requests
.reginstructions in manifest notes #7061$PATH#3685Changes
descriptionto a formal and complete wordinglicensetoGPL-2.0-or-laterand added license URLnotessection using formal language and clear execution instructionsbinentriesenv_add_pathfor automatic PATH integrationshortcutsnames (grouped under “Git*”)post_installscriptsNotes
cmddirectory to thePathenvironment variable, and the useful tools contained in this directory extend well beyondgit,gitk, andscalar. Rather than enumerating these utilities individually in thebinfield, it is more appropriate to add the entirecmddirectory toPath.gpgare not in the same category asssh; however, they are critical during development and should be included in thebinfield for bothgitandgit-with-openssh.install-context.regandinstall-associations.reghave been realigned with the behavior of the official installer, and the associated logic has been refined accordingly.Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>