Fix DeriveIntoActiveModel

[GavenKam]

PR Info

• Closes Fail to derive IntoActiveModel trait for a struct that maps Option<V> to V #2918

Changes

Changed blanket implementation in src/entity/active_value.rs: 110, without which the added test cases cause compilation errors on Derive(DeriveIntoActiveModel).

[tyt2y3]

thank you, this seems to be the correct fix. I wonder why it hasn't been an issue in the past?

[GavenKam]

@tyt2y3 There was an issue #323 before refactoring IntoActiveValue. The focus of discussion was the behavior of Option<V> -> Option<V> - shall Option<V> in an active model represent optional but not null or required but nullable? There was not a final conclusion.
My change makes Option<V>s under all circumstances, no matter Option<V> -> Option<V> or Option<V> -> V, convert into ActiveValue<V>s. If it is the Option<V> -> Option<V> case, ActiveValue<V> is later converted into ActiveValue<Option<V>> back again through ActiveValue<Option<V>>::From<ActiveValue<V>>. However, both cases are affected by the same implementation now.
In current version, the actual behavior of Option<V> in the Option<V> -> Option<V> case is optional but not null. My change do not affect it so it is not a breaking change, but it may not meet your original intention.

[tyt2y3]

@GavenKam thank you for the explanation!

[github-actions]

🎉 Released In 2.0.0-rc.29 🎉

Huge thanks for the contribution!
This feature has now been released, so it's a great time to upgrade.
Show some love with a ⭐ on our repo, every star counts!