Skip to content

Pass flag to optionally do force merge while indexing documents #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narangvivek10 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass flag to optionally do force merge while indexing documents #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/searchscale/lucene/cuvs/benchmarks/BenchmarkConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public class BenchmarkConfiguration {
public String hnswIndexDirPath;
public boolean loadVectorsInMemory;
public boolean skipIndexing;
public boolean forceMerge;

// Lucene HNSW parameters
public int hnswMaxConn; // 16 default (max 512)
Expand Down Expand Up @@ -79,7 +80,8 @@ public String prettyString() {
if (hnswIndexDirPath != null) sb.append("HNSW index directory path is: ").append(hnswIndexDirPath).append('\n');
sb.append("Load vectors in memory before indexing: ").append(loadVectorsInMemory).append('\n');
sb.append("Skip indexing (and use existing index for search): ").append(skipIndexing).append('\n');

sb.append("Do force merge while indexing documents: ").append(forceMerge).append('\n');

sb.append("------- algo parameters ------\n");
if (isLucene()) {
sb.append("hnswMaxConn: ").append(hnswMaxConn).append('\n');
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/com/searchscale/lucene/cuvs/benchmarks/LuceneCuvsBenchmarks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,11 @@ private static void indexDocuments(IndexWriter writer, BenchmarkConfiguration co
pool.shutdown();
pool.awaitTermination(Long.MAX_VALUE, TimeUnit.SECONDS);

if (config.forceMerge) {
log.info("Force merge is enabled.");
writer.forceMerge(1);
}

// log.info("Calling forceMerge(1).");
// writer.forceMerge(1);
log.info("Calling commit.");
Expand Down