Change default delete action to send to Recycling Bin

[cooperaustinj]

Change the default Delete handling to send files to the Recycling Bin instead of permanently deleting them. Add a Shift state to the Content Card to reveal a Permanently Delete button with confirmation.

#96

[cooperaustinj]

I've had a few issues with:

• Bun
• Husky deprecation notice
• Formatting (both prettier and dotnet)

Both dotnet and prettier are adding formatting changes to other files. Might be easiest to have a call because while I could fix these for myself, I don't want to ruin your local set up. I'm not sure if the issues are specific to me or missing set up steps/etc.

[Segergren]

Hi and thanks!
Does this handle files that are larger than the Recycling Bin allows? And wouldn't this cause issues with disk storage being filled up almost all the time? I've had other users suggest this feature, but I'm not sure if it should be a default.

[Segergren]

The formatting issue is probably me having it set up wrong 🥲

[cooperaustinj]

Hi and thanks!
Does this handle files that are larger than the Recycling Bin allows? And wouldn't this cause issues with disk storage being filled up almost all the time? I've had other users suggest this feature, but I'm not sure if it should be a default.

Good call on the large size. I'm not sure yet.

I also considered changing the button to "Sent to Recycling Bin" or something clearly showing it would go there. Then still having Shift to enable permanently deleting. Could also just have both delete buttons show always.

I think the risk of accidentally permanently deleting a potentially important clip while cleaning up others is quite high, to warrant a default change.

[ShaneIsrael]

Would be nice if instead of a "shift state" there was just a setting for what the default delete action does.

Personally, I never want my deletions in the recycle bin. I want them permanently gone. So having to "shift" delete every time would feel kinda tedious.

[Segergren]

Yes, it would need to be a setting, with off by default.
Also need to look into how this handles large files as the recycle bin doesn't allow too large files if I'm not wrong.
This also makes the Storage Limit feature not work as intended. It's there to prevent filling the entire drive with videos. With the recycle bin feature turned on, the user would probably reach the drive limit often and it would be a bad user experience.